Hi Denis, On Thu, Nov 01, 2018 at 09:48:24AM -0500, Denis Kenzior wrote: > Hi Clement, > > On 10/15/2018 12:27 PM, Clement Viel wrote: > >--- > > AUTHORS | 1 + > > Please don't include AUTHORS changes. One of the maintainers will take care > of it. > > > doc/sim800-modem.txt | 11 +++++++++++ > > 2 files changed, 12 insertions(+) > > create mode 100644 doc/sim800-modem.txt > > > >diff --git a/AUTHORS b/AUTHORS > >index 2d360e6..a8362c8 100644 > >--- a/AUTHORS > >+++ b/AUTHORS > >@@ -138,3 +138,4 @@ Florent Beillonnet <[email protected]> > > Martin Hundebøll <[email protected]> > > Julien Tournier <[email protected]> > > Nandini Rebello <[email protected]> > >+Clement Viel <[email protected]> > >diff --git a/doc/sim800-modem.txt b/doc/sim800-modem.txt > >new file mode 100644 > >index 0000000..7220cb8 > >--- /dev/null > >+++ b/doc/sim800-modem.txt > >@@ -0,0 +1,11 @@ > >+SIM800 modem usage > >+=================== > >+ > >+To enable SIM800 module support you need to put the following > >+udev rule into appropriate file in /{etc,lib}/udev/rules.d: > >+ > >+KERNEL=="ttyS2", ENV{OFONO_DRIVER}="sim800" > >+ > >+Sim800 driver code is merged with sim900's. So, to add modifications to > >sim800 driver, sim900.c file must be edited > >+accordingly. > >+To differentiate the two modems, developpers must use the "modem_type" > >field of sim900_data > typo > > structure. > > > > Also, we can't have people hand-editing driver code to distinguish between > one device and another. You've already went to the trouble of creating a > separate sim800 driver (which I do not think is the right approach at all), > why not take advantage of that fact with an appropriate probe() function or > something?
These indications were targeting developpers to warn them about the fact that sim800 and sim900 drivers are merged. I'll remove these lines > > Anyway, I still think you should be querying +CGMM or ATI or whatever to > figure out the modem model automatically and not rely on the user to set > this up. Yep this will be done. > Regards, > -Denis Regards Clem _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
