On Wed, Nov 07, 2018 at 03:02:54PM +0100, Jonas Bonn wrote:
> 
> 
> On 07/11/2018 15:00, Clement Viel wrote:
> >---
> >  plugins/udevng.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/plugins/udevng.c b/plugins/udevng.c
> >index ff6e1fc..d0a849d 100644
> >--- a/plugins/udevng.c
> >+++ b/plugins/udevng.c
> >@@ -1308,6 +1308,7 @@ static struct {
> >     { "calypso",    setup_serial_modem      },
> >     { "cinterion",  setup_serial_modem      },
> >     { "nokiacdma",  setup_serial_modem      },
> >+    { "sim800",     setup_serial_modem      },
> 
> Right... that's much simpler.  And given that you are extending the sim900
> driver to handle the sim800 model, you don't need the above line either.
> 
> /Jonas
> 
> >     { "sim900",     setup_serial_modem      },
> >     { "wavecom",    setup_wavecom           },
> >     { "tc65",       setup_tc65              },
> >
I think I must keep this line because the udev rule added by the user will 
specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what to do 
with that.
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to