Hi Denis,
On Wed, Jan 2, 2019 at 7:44 PM Denis Kenzior <[email protected]> wrote:
>
> Hi Khaled,
>
> On 01/02/2019 09:49 AM, Khaled ROMDHANI wrote:
> > when the voice call driver is probing, I noticed sometimes
> > a CME Error with the code = 4 (operation not supported)
> > related to AT commands "AT+CSSN=1,1" and "AT^SLCC=1".
> >
> > In the current voice call implementation for Gemalto modems
> > the ofono_voicecall_create() is called on the gemalto_pre_sim().
> > The sim is not totaly readed by the module, it is not yet
> > online which is causing a sporadic problem at driver
> > intialization also when launching some outgoing/incoming calls.
> >
> > This change moves the ofono_voicecall_create() to the
> > gemalto_post_online() to be sure that sim is well registred
> > and online.
> >
> > Signed-off-by: khaled romdhani <[email protected]>
>
> No Signed-off-by for oFono please...
>
> > ---
> > plugins/gemalto.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/plugins/gemalto.c b/plugins/gemalto.c
> > index 2f84258..eb782a7 100644
> > --- a/plugins/gemalto.c
> > +++ b/plugins/gemalto.c
> > @@ -573,9 +573,6 @@ static void gemalto_pre_sim(struct ofono_modem *modem)
> > ofono_devinfo_create(modem, 0, "atmodem", data->app);
> > ofono_location_reporting_create(modem, 0, "gemaltomodem", data->app);
> >
> > - ofono_modem_set_integer(modem, "GemaltoVtsQuotes", 1);
> > - ofono_voicecall_create(modem, 0, "gemaltomodem", data->app);
> > -
> > data->sim = ofono_sim_create(modem, OFONO_VENDOR_GEMALTO, "atmodem",
> > data->app);
> >
> > @@ -604,11 +601,6 @@ static void gemalto_post_sim(struct ofono_modem *modem)
> >
> > ofono_ussd_create(modem, 0, "atmodem", data->app);
> >
> > - ofono_call_forwarding_create(modem, 0, "atmodem", data->app);
>
> Do note that call_forwarding can be post_sim, but either works...
>
> > - ofono_call_settings_create(modem, 0, "atmodem", data->app);
> > - ofono_call_meter_create(modem, 0, "atmodem", data->app);
> > - ofono_call_barring_create(modem, 0, "atmodem", data->app);
> > -
> > if (!g_strcmp0(model, GEMALTO_MODEL_ALS3_PLS8x))
> > ofono_lte_create(modem, OFONO_VENDOR_GEMALTO,
> > "atmodem", data->app);
> > @@ -621,6 +613,14 @@ static void gemalto_post_online(struct ofono_modem
> > *modem)
> > DBG("%p", modem);
> >
> > ofono_netreg_create(modem, OFONO_VENDOR_GEMALTO, "atmodem",
> > data->app);
> > +
> > + ofono_modem_set_integer(modem, "GemaltoVtsQuotes", 1);
> > + ofono_voicecall_create(modem, 0, "gemaltomodem", data->app);
>
> This does imply that no emergency calls are possible when no SIM is
> inserted or the PIN not in 'READY' state.
Indeed, it won't be possible in ofono with this modification.
However I have two points:
- more and more countries require a SIM also for emergency call.
Namely, the EU has voted a directive for it to avoid hoax calls (it
doesn't matter then if it cannot register, the important thing is that
the network can get the SIM IMEI).
- the new eCalls require SIM & registration
In my opinion, emergency calls should be treated in a different atom,
and simply ignored by the voicecall one.
>
> > +
> > + ofono_call_forwarding_create(modem, 0, "atmodem", data->app);
> > + ofono_call_settings_create(modem, 0, "atmodem", data->app);
> > + ofono_call_meter_create(modem, 0, "atmodem", data->app);
> > + ofono_call_barring_create(modem, 0, "atmodem", data->app);
> > }
> >
> > static struct ofono_modem_driver gemalto_driver = {
> >
>
> Regards,
> -Denis
Regards,
Giacinto
> _______________________________________________
> ofono mailing list
> [email protected]
> https://lists.ofono.org/mailman/listinfo/ofono
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
