After the convertion to l_uintset, the creation of new contexts fails
due to a range error being returned from l_uintset_find_unused().

The error happens because the uinset is created with a min-value of 1,
but the start-value passed to l_uintset_find_unused() is initialized as
0.

Fix this by using the minimum id when last used id is not yet
initialized.
---
 src/gprs.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/gprs.c b/src/gprs.c
index 58a998ca..92820e60 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -2334,7 +2334,11 @@ static void provision_context(const struct 
ofono_gprs_provision_data *ap,
                        strlen(ap->message_center) > MAX_MESSAGE_CENTER_LENGTH)
                return;
 
-       id = l_uintset_find_unused(gprs->used_pids, gprs->last_context_id);
+       if (!gprs->last_context_id)
+               id = l_uintset_get_min(gprs->used_pids);
+       else
+               id = l_uintset_find_unused(gprs->used_pids,
+                                               gprs->last_context_id);
        if (id > l_uintset_get_max(gprs->used_pids))
                return;
 
-- 
2.20.1

_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to