Hi Martin,

It doesn't work, because the early return skips the call to ppp_set_auth() in the last switch block.

Calling the function before returning works though:

This is still wrong. lcp_rcr processes many options, AUTH_PROTO being only a small subset. So you can't simply return RCR_ACCEPT here.

rfc1661 doesn't seem to allow one to reject authentication besides using an RCR_REJECT. Maybe someone can play with sending a RCR_NAK and suggesting 0 as the AUTH_PROTO.

I suspect the real fix is to force G_AT_PPP_METHOD_CHAP in at_gprs_activate_primary even if OFONO_GPRS_AUTH_METHOD_NONE is given in the context configuration.

Unless of course the modem firmware supports taking the username / password via AT commands or can understand an RCR_REJECT without going into an infinite loop.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to