Hi Philippe,

On 02/15/2019 06:11 AM, [email protected] wrote:
From: Philippe De Swert <[email protected]>

QUIRCK: For some reason I really need to force the use of the atd99 command 
here.
---
  drivers/atmodem/gprs-context.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index 93894efd..a0776f2a 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -214,7 +214,7 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, 
gpointer user_data)
                return;
        }
- if (gcd->use_atd99)
+       if (gcd->use_atd99 || gcd->vendor == OFONO_VENDOR_UBLOX)
                sprintf(buf, "ATD*99***%u#", gcd->active_context);
        else
                sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
@@ -457,6 +457,9 @@ static int at_gprs_context_probe(struct ofono_gprs_context 
*gc,
        case OFONO_VENDOR_SIMCOM_SIM900:
                gcd->use_atd99 = FALSE;
                break;
+       case OFONO_VENDOR_UBLOX:
+               gcd->use_atd99 = TRUE;
+               break;

So why use both use_atd99 and a vendor quirk above? Also, you're affecting other uBlox users, so do you want to introduce a different VENDOR quirk instead?

        default:
                g_at_chat_send(chat, "AT+CGDATA=?", cgdata_prefix,
                                                at_cgdata_test_cb, gc, NULL);


Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to