Hi Denis,

Xmm modem send proactive command for set up menu only at sim initialization, 
also depending upon if stk is enabled. So before sim initialization we have to 
make sure the stk is enabled otherwise proactive command is missed.

Regards
Antara

-----Original Message-----
From: Denis Kenzior [mailto:[email protected]] 
Sent: Thursday, May 30, 2019 9:37 PM
To: Borwankar, Antara <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] xmm7modem: enabling simtoolkit for xmm7modem

Hi Antara,

On 05/30/2019 04:25 AM, Antara Borwankar wrote:
> added code to create stk atom in xmm7modem plugin
> ---
>   plugins/xmm7xxx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c index 
> 23a7d4e..da6622b 100644
> --- a/plugins/xmm7xxx.c
> +++ b/plugins/xmm7xxx.c
> @@ -1225,6 +1225,7 @@ static void xmm7xxx_pre_sim(struct ofono_modem *modem)
>       ofono_devinfo_create(modem, OFONO_VENDOR_IFX, "atmodem", data->chat);
>       data->sim = ofono_sim_create(modem, OFONO_VENDOR_XMM, "atmodem",
>                                       data->chat);
> +     ofono_stk_create(modem, OFONO_VENDOR_XMM, "atmodem", data->chat);

Why pre_sim?  Generally the SIM needs to be initialized before any part of STK 
makes sense...  Also, that atom isn't really setup to be used when no SIM is 
inserted for example.

>   }
>   
>   static void set_online_cb(gboolean ok, GAtResult *result, gpointer 
> user_data)
> 

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to