Hi Martin,
On 06/21/2019 03:21 PM, Martin Hundebøll wrote:
Hi Denis,
On 21/06/2019 19.54, Denis Kenzior wrote:
What compiler are you using? gcc really needs to make up its mind
whether it warns about enums or doesn't. The behavior between
versions is nuts.
% arm-oe-linux-gnueabi-gcc --version
arm-oe-linux-gnueabi-gcc (GCC) 8.2.0
So I need this fix when building for my embedded platform using a
compiler from the Yocto SDK. Thanks for applying.
My up-to-date host compiler has no complaints regarding enums :)
But with gcc-9.1 I get a few of these now:
../git/gisi/modem.c: In function ‘modem_subs_update’:
../git/gisi/modem.c:383:3: error: converting a packed ‘struct
sockaddr_pn’ pointer (alignment 1) to a ‘const struct sockaddr’ pointer
(alignment 2) may result in an unaligned pointer value
[-Werror=address-of-packed-member]
383 | sizeof(commgr));
| ^~~~~~
In file included from ../git/gisi/message.h:32,
from ../git/gisi/modem.c:36:
../git/gisi/phonet.h:49:8: note: defined here
49 | struct sockaddr_pn {
| ^~~~~~~~~~~
Yeah we've seen this one as well. The problem is that there's not a
whole lot we can do but #pragma this out as it is a structure that is
part of the uapi.
It's not a problem though, since I don't enable gisi in my build - now
you know :)
As do I honestly. That driver has not been maintained in some time.
I'm considering removing it from the tree entirely.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
