On Thu 2019-07-18 13:49:34, Martin Hundebøll wrote:
> ---
>  test/process-context-settings | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/process-context-settings b/test/process-context-settings
> index 1d30b30d..a536a771 100755
> --- a/test/process-context-settings
> +++ b/test/process-context-settings
> @@ -41,14 +41,14 @@ for path, properties in modems:
>                       print("    IP address is %s" % (address))
>                       print("    Gateway is %s" % (gateway))
>  
> -                     cmd = "ifconfig " + interface + " " + address
> -                     cmd += " netmask 255.255.255.255"
> +                     cmd = "ip address add dev " + interface + " " + address
> +                     cmd += "/32"
>                       os.system(cmd);
>  
>                       for i in settings["DomainNameServers"]:
>                               print("    Nameserver is %s" % (i))
>  
> -                             cmd = "route add -host " + i
> +                             cmd = "ip route add  " + i
>                               cmd +=" dev " + interface
>                               os.system(cmd);

So.. you move from one tool to another one, fixing it on some systems
and braking on some.

But I guess better solution would be to use python module, not execing
external programs.

...which certainly should not be executed using os.system(). Network
interface called `> /etc/passwd` would be a lot of phun, right? :-).

                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to