Hi Denis,

Den mån 12 aug. 2019 kl 19:28 skrev Denis Kenzior <[email protected]>:

> Hi Richard,
>
> >> +    void (*get_active_auto_context)(struct ofono_gprs *gprs,
> >> +                    ofono_gprs_active_context_cb_t cb,
> >> +                    void *data);
> >
> > list_active_contexts?  Also, since there can in theory be multiple ones
> > of these, I'd do something like:
> >
> > typedef void (*ofono_gprs_active_context_cb_t)(int cid, const char *apn,
> >                          void *data);
> >
> > void (*list_active_contexts)(struct ofono_gprs *gprs,
> >              ofono_gprs_active_context_cb_t active_cb,
> >              ofono_gprs_cb_t finished_cb);
> >
>
> As an alternative to the above you can simply do:
>
> void (*list_active_contexts)(struct ofono_gprs *gprs,
>                                 ofono_gprs_cb_t cb);
>
> And direct the driver to issue N ofono_gprs_context_activated calls
> followed by cb.  Where N is the number of active contexts.
>

Makes more sense, then there is no need for a "strange" call with -1 and
NULL.


>
> Regards,
> -Denis
>

--Richard
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to