Hi Richard, Jonas,

On 8/21/19 1:01 AM, Jonas Bonn wrote:
Hi Richard,

On 20/08/2019 17:56, [email protected] wrote:
From: Richard Röjfors <[email protected]>

This reverts commit 1fd419e5b4b3a87673f8e0219edb0f3ed9fca774.

This patch is fine and certainly necessary in the context of this series.  Posting it as a 'revert', however, is a bit unsavoury.

A reverted patch implies that it was somehow wrong or inappropriate. That's not the case here.  This code has become superfluous in the face of other changes that have been made in the tree.

Just squash these two revert patches into one "forward looking" patch. The fact that the change effectively constitutes a 'revert' is moot.


So what I ended up doing was to squash patch 2 & 3 and reword the description a bit, dropping the 'revert' heading per your wishes. Let me know if you're fine with that.

Otherwise, all 3 applied.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to