Hi Jonas,
Can data->init_cmd be 0 here?
Yes... init_cmd gets cleared in init_cmd_cb when the command succeeds.
We reuse the callback to get an extra 1 second delay (which we require)
before continuing with the initialization. There's a comment about this
in init_cmd_cb above.
Ah right. I read that comment but didn't put the two together. Still,
seems like you could use l_timeout_set_callback to make life easier for
yourself.
+ g_at_chat_unref(data->aux);
+ data->aux = NULL;
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+ ofono_modem_set_powered(modem, FALSE);
+ return;
This return isn't needed, and you may want to just put these
statements into a common utility since you copy-paste this in two places.
Yes, but it's not needed anywhere else... are you requiring a static
inline function for this or can I just resubmit this without the return
statement?
I count like 3 places in ublox.c that do this 5 line incantation and
you're adding 2 more.
Anyhow, I can take your patch and fix this separately or you can do this
right ;)
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
