Hi Antara,
On 9/26/19 4:46 AM, Borwankar, Antara wrote:
Hi Denis,
Regarding your below query
- Can you tell me why this new addition uses vid/pid with a 0x prefix while the
rest of the table does not? It seems weird & inconsistent.
Actually in case of pci device vendor and device id read using libudev API is returning as
"0x8086" and "0x7560" strings respectively. So I have added the same values in
vendor_list table.
That is strange. Okay, so maybe we should just add a different look-up
table to handle this. Perhaps pci_driver_list[] and use vids/pids with
0x prefixes there.
In case of usb device the vendor and device strings returned by same libudev API does not
have "0x" prefix. I don’t have any idea why it is so.
If you insist I can remove this prefix 0x from vendor_list table and change the
implementation of check_pci_device() function to handle comparison of vendor
and model strings with vid, pid form vendor_list.
Yep, that might be another alternative. I'd be fine with either.
Having some entries with 0x and some without will confuse people and
lead to bugs.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
