Hi Pavel,
On 9/15/20 8:23 AM, Pavel Machek wrote:
Droid 4 modem is "special" (aka broken) so and getting incoming SMSes
to work is quite tricky. This should get it right.
---
drivers/atmodem/sms.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index d502da72..f08f2fb1 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -463,7 +463,8 @@ static void at_cmt_notify(GAtResult *result, gpointer
user_data)
decode_hex_own_buf(hexpdu, -1, &pdu_len, 0, pdu);
ofono_sms_deliver_notify(sms, pdu, pdu_len, tpdu_len);
- if (data->vendor != OFONO_VENDOR_SIMCOM)
+ if ((data->vendor != OFONO_VENDOR_SIMCOM) &&
+ (data->vendor != OFONO_VENDOR_DROID))
Fixed up style here per item M4
at_ack_delivery(sms);
return;
<snip>
@@ -858,9 +860,14 @@ static gboolean build_cnmi_string(char *buf, int
*cnmi_opts,
if (!append_cnmi_element(buf, &len, cnmi_opts[0], mode, FALSE))
return FALSE;
+ mode = "21";
+ if (!data->cnma_enabled)
+ mode = "1";
+ if (data->vendor == OFONO_VENDOR_DROID)
+ mode = "2";
+
And here per item M1.
Also, I had to resolve a minor conflict manually. Please rebase against git
HEAD when sending out patches.
Applied, thanks.
Regards,
-Denis
_______________________________________________
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
