Hi Richard,
On 12/20/20 5:18 AM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors <rich...@puffinpack.se>
GCC 10 warns about a couple of implicit conversions;
huawei: Member from the incorrect enum was returned,
both had the value 0, so the code would still work.
drivers/huaweimodem/radio-settings.c: In function ‘band_gsm_from_huawei’:
drivers/huaweimodem/radio-settings.c:107:10: error: implicit conversion from
‘enum ofono_radio_band_umts’ to ‘enum ofono_radio_band_gsm’
[-Werror=enum-conversion]
107 | return OFONO_RADIO_BAND_UMTS_ANY;
util: smsutil and util has an enum each for representing
the same thing; The SMS alphabet. They share the same
values, so an explicit type cast makes GCC happy.
src/smsutil.c: In function ‘sms_text_prepare_with_alphabet’:
src/smsutil.c:3594:8: error: implicit conversion from ‘enum sms_alphabet’ to
‘enum gsm_dialect’ [-Werror=enum-conversion]
3594 | alphabet, &used_locking,
---
drivers/huaweimodem/radio-settings.c | 2 +-
src/smsutil.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
I split this into two commits and applied. Thanks!
Regards,
-Denis
_______________________________________________
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
