>>>>+static void *IndexListRemoveFirst(INDEX_LIST *pIndexList)
>>>+{
>>>+ return IndexListRemove(pIndexList, pIndexList->pArray[0].Entry.Next);
>>>+}
>>
>>Doesn't this remove the last entry added to the index, not the first?
>
>I should rename this to IndexListRemoveHead(), since it removes the item at the
>head of the list. It's only called to remove items during cleanup.
I don't think that the Head/Tail concept applies well here because there's no
indication when you insert whether you're inserting at the head or tail. You
could rename Insert to Push, and RemoveFirst to Pop as the function is closer
to a stack than a list. Or you could name it
IndexListRemoveEntryThatWasInsertedLast. :)
-Fab
_______________________________________________
ofw mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
