Did you send it before morning coffee or after ? :) Maybe, because it seems obvious. All are agree with the elimination of unnecessary #ifndef's. As to me, go ahead, commit it.
> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Smith, Stan > Sent: Thursday, November 12, 2009 7:32 PM > To: 'Sasha Khapyorsky' > Cc: [email protected]; [email protected] > Subject: [ofw] RE: [PATCH] opensm - use C99 transportable > data type forpointer storage > > Hello, > Can you help me understand why this patch always seems to > fall into a black hole with no feedback? > > Thank you, > > Stan. > > > Stan C. Smith wrote: > > In order to skip the #ifndef __WIN__ around #include <stdint.h>, > > inttypes.h was used. 'inttypes.h' includes stdint.h and > exists in the > > WinOF svn tree. > > OFED opensm builds without problems on EL 5.3. > > > > Signed-off-by: stan smith <[email protected]> > > > > diff --git a/opensm/include/opensm/st.h > b/opensm/include/opensm/st.h > > index 30cc308..ad6c289 100644 > > --- a/opensm/include/opensm/st.h > > +++ b/opensm/include/opensm/st.h > > @@ -39,6 +39,7 @@ > > #define ST_INCLUDED > > > > #include <stdlib.h> > > +#include <inttypes.h> > > > > #ifdef __cplusplus > > # define BEGIN_C_DECLS extern "C" { > > @@ -49,7 +50,7 @@ > > #endif /* __cplusplus */ > > > > BEGIN_C_DECLS > > -#define st_ptr_t unsigned long > > +#define st_ptr_t uintptr_t > > typedef st_ptr_t st_data_t; > > > > #define ST_DATA_T_DEFINED > > _______________________________________________ > ofw mailing list > [email protected] > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw > _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
