I'll look at the alternatives for solving this soon, but we need to remember:
Not changing the api is very good at the short term but looks very ugly at the long term. This means that years from now, anyone that will write or read our code will have to witness the hacks that we are doing now. (parameters being added at the wrong places, etc). Considering the number of users that we have (compared to windows for example) and the amount of testing that we can do, I'm not sure that this is the right decision. Thanks Tzachi > -----Original Message----- > From: Sean Hefty [mailto:[email protected]] > Sent: Friday, February 19, 2010 10:04 PM > To: 'James Yang'; Tzachi Dar; ofw_list > Subject: RE: [ofw] API breakage in trunk > > >It seems we have to stuck with old ib_port_attr_t. > > > >To get new port attribute, we can add these new definition > at the end > >of ib_ca_attr_t, I'm assuming its size is OK to expand... > > I think it's okay adding it to the end of ib_ca_attr_t. Some other > alternatives: > > 1. Define a new structure and interface that provides this data. > 2. Define separate ib_port_attr_t for kernel and user space. > Add this to the kernel, but not user space. Select a > different way for exposing this data to user space > application, if it is needed. > > > _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
