Tzachi Dar wrote: > Actually the structure is also defined in the ib_types_extended.h > which is also under opensm directory.
Curious, I do not find this file anywhere under trunk? Perhaps it is not needed? I do find the file under WOF2-2 in the old (3.0.0) opensm implementation. The 3.0.0 src is ONLY in WOF 2.2 as an escape hatch should opensm 3.3.3 not perform correctly in some case; point being the 3.0.0 opensm source is not in the trunk. stan. > > Do we want to change that place? > > Thanks > Tzachi > >> -----Original Message----- >> From: Smith, Stan [mailto:[email protected]] >> Sent: Monday, March 08, 2010 6:46 PM >> To: Hefty, Sean; Tzachi Dar; [email protected] >> Subject: RE: [ofw] [RFC] [PATCH] ibal: move transport type attribute >> >> Sean Hefty wrote: >>>> Seems fine by me. I believe that we should do the same in all the 3 >>>> definitions of ib_port_attr_t to keep them the same. >>> >>> We have 3 definitions of the same structure? Where are the other >>> two? I would vote for killing the duplicates >>> >>> _______________________________________________ >>> ofw mailing list >>> [email protected] >>> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw >> >> If Tzachi is speaking to the ib_types.h found in the opensm\ >> source (Trunk\ulp\opensm\user\include\iba), then I would >> suggest skipping any mods there. This file is for reference >> purposes only; to aid in figuring out the differences between >> the Windows snapshot of opensm and the 'latest' Linux version >> when updating the windows opensm. The issue is the windows >> inc\iba\ib_types.h differs substantially from the Linux >> opensm version. >> The file 'ib_types.h' is not utilized in the windows build >> process and 'could' be removed although it's removal implies >> additional work for the next opensm update. >> >> stan. _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
