________________________________ From: Irena Gannon [mailto:[email protected]] Sent: Wednesday, September 15, 2010 5:48 AM To: Smith, Stan; [email protected] Cc: Hal Rosenstock Subject: RE: [ofw] [patch][osmtest] Fix lid parameter passing
Hello, Hal explained to me that something was wrong with the OpenSM lid assignment of 1 when LMC > 0. There were some changes in OpenSM LID assignment that addresses this beyond the version that the problem was found in (3.3.3) For the version of our trunk and yours the fix is irrelevant because the OpenSM there (3.3.6) handles that problem itself. Please ignore this patch. Thank you OK, thank you for the detailed explanation; it all makes sense now. stan. From: Smith, Stan [mailto:[email protected]] Sent: Monday, September 13, 2010 7:29 PM To: Irena Gannon; [email protected] Subject: RE: [ofw] [patch][osmtest] Fix lid parameter passing What is the story here? Why is the change needed? How does the problem show up? Again, if this is not a windows local mod, then the patch needs to go to Sasha. At the minimum, please include some explanation as to why the patch is good and necessary. thanks, stan. ________________________________ From: [email protected] [mailto:[email protected]] On Behalf Of Irena Gannon Sent: Sunday, September 12, 2010 3:07 AM To: [email protected] Subject: [ofw] [patch][osmtest] Fix lid parameter passing Index: D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmtest.c =================================================================== --- D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmtest.c (revision 6460) +++ D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmtest.c (revision 6461) @@ -6019,7 +6019,7 @@ goto Exit; if (lmc != 0) { - test_lid = cl_ntoh16(p_osmt->local_port.lid + 1); + test_lid = cl_ntoh16(p_osmt->local_port.lid); /* Another GUIDInfo Record test */ memset(&context, 0, sizeof(context)); Index: D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmt_slvl_vl_arb.c =================================================================== --- D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmt_slvl_vl_arb.c (revision 6460) +++ D:/Windows/MLNX_VPI_2_1_2/ulp/opensm/user/osmtest/osmt_slvl_vl_arb.c (revision 6461) @@ -510,7 +510,7 @@ goto Exit; if (lmc != 0) { - test_lid = cl_ntoh16(p_osmt->local_port.lid + 1); + test_lid = cl_ntoh16(p_osmt->local_port.lid); status = osmt_query_vl_arb(p_osmt, test_lid, 0, 1, NULL); if (status != IB_SUCCESS)
_______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
