Applied 3097 -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Uri Habusha Sent: Monday, February 14, 2011 9:51 PM To: Hefty, Sean; [email protected] Subject: Re: [ofw] patch[ipoib]: fix a deadlock
The synchronize mechanism here is bad. However for now I don't want to make a wide change and I want to resolve the specific deadlock. We are now in the middle of reexamination process of IPoIB. We check what is the best way to improve the quality and the maintenance process of the IPoIB. When we get a decision we'll update the community. Uri -----Original Message----- From: Hefty, Sean [mailto:[email protected]] Sent: Monday, February 14, 2011 5:41 PM To: Uri Habusha; [email protected] Subject: RE: patch[ipoib]: fix a deadlock > /* Wait for all readers to complete. */ > > while( p_port->endpt_rdr ) > > - ; > > + { > > + cl_obj_unlock( &p_port->obj ); > > + cl_obj_lock( &p_port->obj ); > > + } How often are there multiple readers? How long does a reader hold the lock for? And do we need to use a spinlock? Also, doesn't complib provide a reader-writer lock abstraction? _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
