>-----Original Message----- >From: [email protected] >[mailto:[email protected]] On Behalf Of Fab >Tillier >Sent: Monday, February 28, 2011 4:46 PM >To: [email protected] >Subject: [ofw] [IPoIB] NdisMSendNetBufferListCompleteX assert > >The assertion at line 1122 in ipoib_port.h seems wrong since the following >code dereferences the NBL. >Is it wrong, or there to cause an assert because of a send error? > >If the latter, a comment would help make the intent clear, as the code looks >wrong as is. > >-Fab
NdisMSendNetBufferListsCompleteX() is completing a 'single' NBL (NetworkBufferList); not a list of NBLs. The code is correctly used in ipoib_port.cpp @ ipoib_port_send(). Although it's usage in ipoib_driver.cpp @ ipoib_send_net_buffer_list() after label 'compl_status:' is incorrect. Appears the comment is wrong w.r.t. NdisMSendNetBufferListsCompleteX() and the for() loop should be extended down to encompass the NdisMSendNetBufferListsCompleteX() call with a single NBL. The dispatch check should be done once prior to entering the for()loop. Tzachi, Alex - do you agree? Stan. >_______________________________________________ >ofw mailing list >[email protected] >http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
