From: Uri Habusha [mailto:[email protected]] Sent: Saturday, July 02, 2011 11:07 PM To: Smith, Stan; Fab Tillier; [email protected] Subject: RE: removing the special debug file
As soon as possible. Give me a green light and I'll do it Please commit ASAP. From: Smith, Stan [mailto:stan. [email protected]] Sent: Friday, July 01, 2011 10:14 PM To: Uri Habusha; Fab Tillier; [email protected] Subject: RE: removing the special debug file Uri, I forged ahead and made the code changes described in your patch file by hand, along with major changes in the WIX installer files. winOFED again builds and installs correctly for win7 & Svr2008 &| R2. When are you planning on committing your patches? From: Uri Habusha [mailto:[email protected]] Sent: Thursday, June 30, 2011 8:28 AM To: Smith, Stan; Fab Tillier; [email protected] Subject: RE: removing the special debug file Updated patch is attached From: Uri Habusha Sent: Thursday, June 30, 2011 11:48 AM To: 'Smith, Stan'; Fab Tillier; [email protected] Subject: RE: removing the special debug file Attached is the patch file. I changed the sources and *.inx file From: Smith, Stan [mailto:[email protected]] Sent: Wednesday, June 29, 2011 10:36 PM To: Uri Habusha; Fab Tillier; [email protected] Subject: RE: removing the special debug file Please see below. From: Uri Habusha [mailto:[email protected]] Sent: Wednesday, June 29, 2011 12:18 PM To: Fab Tillier; Smith, Stan; [email protected] Subject: RE: removing the special debug file No. in many places in build the linking is done with different files in release and in debug. The summaries the work: * Need to fix the sources. Remove different file generation and link * Need to fix inf not copy the *d.dll files. Regarding rc I'm not sure. When you use ndis.sys in debug and release you get the same file description. I don't think we need to act differently. [stan] Just because MS did not do something, does not imply we should propagate their mistakes. The .rc file tag makes it 'very' easy to distinguish Debug vs. Release, otherwise the only way you can tell the difference is if the file size (not 100% accurate). Tagging the .rc file makes debug/release very, very easy to identify when both versions have the same filename! I'll do the work and send the patch for review From: Fab Tillier [mailto:[email protected]] Sent: Wednesday, June 29, 2011 8:11 PM To: Smith, Stan; Uri Habusha; [email protected] Subject: RE: removing the special debug file Can we Just remove the debug DLLs from the INF file and be done with it? -Fab From: [email protected] [mailto:[email protected]] On Behalf Of Smith, Stan Sent: Wednesday, June 29, 2011 9:30 AM To: Uri Habusha; [email protected] Subject: Re: [ofw] removing the special debug file Hello Uri, I believe the current mode of operation is to copy-rename-replace the free version of the file with debug version of the file. Removing the 'd' for debug filename convention will be a fair amount of work impacting 'many' build and release files. That said, I personally have no problems with dropping the special debug name of the file. I would request that all .rc files have the correctly working '#if DBG' with '#define VER_FILEDESCRIPTION_STR' containing some indication the version is Debug/Checked. The absence of Debug/Checked would imply a free/released version of the module. With the correct #define VER_FILEDESCRIPTION_STR definition, one can hold the mouse-point over the explorer filename and determine if the module is Debug or Free. Fortunately many modules already support this functionality. #if DBG #define VER_FILEDESCRIPTION_STR "IP over InfiniBand (Connected Mode) NDIS 6 Miniport (Checked)" #else #define VER_FILEDESCRIPTION_STR "IP over InfiniBand (Connected Mode) NDIS 6 Miniport" #endif Who is going to do this conversion work? Stan. From: Uri Habusha [mailto:[email protected]] Sent: Wednesday, June 29, 2011 1:21 AM To: [email protected]; Smith, Stan Subject: removing the dpecial debug file Currently the OFA build creates different files for debug and release version (i.e complib.dll for release and complibd.dll for debug). I don't know what was the reason to do it in this way, but I know that there is no other product that do it. If you wants to debug an issue you can install the debug version that contains the debug dll. Using different names complicates our installation package and testing. I want to change the code to use same file name for debug and release. Please let me know if there is any reason not doing it. Thanks Uri Uri Habusha Windows SW Development Lead Mellanox Technologies P.OBox 586, Yokneam 20692 Israel
_______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
