We got a BSOD in cl_thread_destroy() function on ZwClose().
The code review showed that the old mechanism doesn't take a reference on the
created thread and waits for the thread exit while it may already be a
non-existed object.
It also closes the thread handle too late.
Please, review the patch.
Index: B:/users/leonid/svn/winib/trunk/core/complib/kernel/cl_thread.c
===================================================================
--- B:/users/leonid/svn/winib/trunk/core/complib/kernel/cl_thread.c (revision
8921)
+++ B:/users/leonid/svn/winib/trunk/core/complib/kernel/cl_thread.c
(revision 8922)
@@ -38,11 +38,8 @@
__thread_callback(
IN cl_thread_t* p_thread )
{
- /* Store the thread pointer so that destroy and
is_current_thread work. */
- p_thread->osd.p_thread = KeGetCurrentThread();
-
/* Bump the thread's priority. */
- KeSetPriorityThread( p_thread->osd.p_thread,
LOW_REALTIME_PRIORITY );
+ KeSetPriorityThread( KeGetCurrentThread(), LOW_REALTIME_PRIORITY
);
/* Call the user's thread function. */
(*p_thread->pfn_callback)( (void*)p_thread->context );
@@ -91,6 +88,15 @@
if( !NT_SUCCESS( status ) )
return( CL_ERROR );
+ /* get pointer to thread object to wait on it's exit */
+ status = ObReferenceObjectByHandle( p_thread->osd.h_thread,
THREAD_ALL_ACCESS,
+ NULL, KernelMode,
(PVOID*)&p_thread->osd.p_thread, NULL );
+ CL_ASSERT(status == STATUS_SUCCESS); // According to MSDN, must succeed if
I set the params
+
+ /* Close the handle to the thread. */
+ status = ZwClose( p_thread->osd.h_thread );
+ CL_ASSERT(NT_SUCCESS(status)); // Should always succeed
+
return( CL_SUCCESS );
}
@@ -112,8 +118,8 @@
KeWaitForSingleObject( p_thread->osd.p_thread, Executive,
KernelMode,
FALSE, NULL );
- /* Close the handle to the thread. */
- ZwClose( p_thread->osd.h_thread );
+ /* Release the reference to thread object */
+ ObDereferenceObject( p_thread->osd.p_thread );
/*
* Reset the handle in case the user calls destroy and the
thread is
_______________________________________________
ofw mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
