On Mon, Oct 17, 2011 at 2:39 PM, Smith, Stan <[email protected]> wrote:
> Done. > > > Is this using 1024 or BUFSIZ ? -- Hal > > > ** ** > > Thanks.**** > > ** ** > > Revision: 3309**** > > Author: [email protected]**** > > Date: 11:33:08 AM, Monday, October 17, 2011**** > > Message:**** > > [OPENSM] side-step win8 assert; use agreed upon BUFSIZ value.**** > > ----**** > > Modified : /gen1/branches/mlx4/ulp/opensm/user/opensm/main.c**** > > ** ** > > Revision: 3310**** > > Author: [email protected]**** > > Date: 11:34:48 AM, Monday, October 17, 2011**** > > Message:**** > > [OPENSM] side-step win8 assert; use agreed upon BUFSIZ value.**** > > ----**** > > Modified : /gen1/trunk/ulp/opensm/user/opensm/main.c**** > > ** ** > > ** ** > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Smith, Stan > *Sent:* Monday, October 17, 2011 9:10 AM > *To:* Leonid Keller > *Cc:* ofw_list > *Subject:* Re: [ofw] [bug] Assert in opensm 3.3.11**** > > ** ** > > Hello,**** > > I too noticed this change, no assert() fire on win7; not surprising. > Seems the discussion Alex, Hal and others had w.r.t. Windows setvbuf(BUFSIZ) > did not make it into the mainline.**** > > I’d prefer BUFSIZ as it’s a well-recognized system wide entity, although > 1024 would work equally well.**** > > I’ll update, thanks for pointing out the omission.**** > > ** ** > > Stan.**** > > ** ** > > ** ** > > ** ** > > *From:* Leonid Keller [mailto:[email protected]] > *Sent:* Saturday, October 15, 2011 11:23 AM > *To:* Smith, Stan > *Cc:* ofw_list > *Subject:* [ofw][bug] Assert in opensm 3.3.11**** > > ** ** > > Hi Stan,**** > > ** ** > > I got an assert in Win8 on setvbuf (see below).**** > > It states that *size* should be at least 2.**** > > Also MSDN agrees with that:**** > > *size * > > Buffer size in bytes. Allowable range: 2 <= size <= INT_MAX (2147483647)** > ** > > Here is the suggested patch.**** > > ** ** > > Index: main.c**** > > ===================================================================**** > > --- main.c (revision 8962)**** > > +++ main.c (revision 8963)**** > > @@ -732,7 +732,7 @@**** > > };**** > > **** > > /* force stdout to be line-buffered */**** > > - setvbuf(stdout, NULL, _IOLBF, 0);**** > > + setvbuf(stdout, NULL, _IOLBF, 1024);**** > > **** > > /* Make sure that the opensm and complib were compiled > using**** > > same modes (debug/free) */**** > > _______________________________________________ > ofw mailing list > [email protected] > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw >
_______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
