On Mon, Oct 05, 2009 at 02:50:54PM -0700, [email protected] 
wrote:
> 
> http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=704
> 
> Ralph Versteegen <[email protected]> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[email protected]
> 
> --- Comment #6 from Ralph Versteegen <[email protected]> 2009-10-05 14:50:51 
> PDT ---
> (In reply to comment #5)
> > I am wondering if this bug is related to the numerous memory leaks we have.
> > 
> > I can easily see the memory leaks causing more problems on a large game, and
> > more problems when a game has been open and worked-on for a long period of
> > time.
> 
> I assumed this bug was similar to bug 233, which haunts me from time to time,
> and which I personally believe is due to thread safety bugs in the FB runtime
> library.
> 
> Memory leaks is an interesting idea, and it might have something to do with 
> the
> internal temporary string and array arrays in the FB runtime.
> 
> Yesterday I found that Game leaks 8MB (which is of course massive compared to
> normal memory usage) when opening and upgrading the latest SVN copy of SoJ
> (which is of course much newer than first release). Top leakers:
> 
> ==7074== 58,254 bytes in 798 blocks are definitely lost in loss record 690 of
> 698
> ==7074==    at 0x47E08EC: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
> ==7074==    by 0x811AF0A: fb_hStrRealloc (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811A192: fb_StrAssignEx (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811A310: fb_StrAssign (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x80E0616: LOADENEMYDATA (common.bas:820)
> ==7074==    by 0x80EAE48: UPGRADE (common.bas:2248)
> ==7074==    by 0x80528A0: main (game.bas:281)
> ==7074== 
> ==7074== 58,327 bytes in 799 blocks are definitely lost in loss record 691 of
> 698
> ==7074==    at 0x47E08EC: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
> ==7074==    by 0x811AF0A: fb_hStrRealloc (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811A192: fb_StrAssignEx (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811A310: fb_StrAssign (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x80E06C6: SAVEENEMYDATA (common.bas:829)
> ==7074==    by 0x80EAE86: UPGRADE (common.bas:2251)
> ==7074==    by 0x80528A0: main (game.bas:281)
> 
> ==7074== 696,696 bytes in 2,233 blocks are definitely lost in loss record 697
> of 698
> ==7074==    at 0x47DFC2B: calloc (in
> /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
> ==7074==    by 0x81157A6: fb_hArrayAlloc (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811587A: hRedim (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x81158E0: fb_ArrayRedimEx (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x80D99DB: _Z14LOADATTACKDATARAii (loading.bas:1371)
> ==7074==    by 0x80EAB9F: UPGRADE (common.bas:2224)
> ==7074==    by 0x80528A0: main (game.bas:281)
> ==7074== 
> ==7074== 6,841,672 bytes in 8,303 blocks are definitely lost in loss record 
> 698
> of 698
> ==7074==    at 0x47DFC2B: calloc (in
> /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
> ==7074==    by 0x81157A6: fb_hArrayAlloc (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x811587A: hRedim (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x81158E0: fb_ArrayRedimEx (in
> /mnt/common/ohrrpgce/source/wip/ohrrpgce-game)
> ==7074==    by 0x80D8CB9: SAVETEXTBOX (loading.bas:1201)
> ==7074==    by 0x80EBA8B: UPGRADE (common.bas:2356)
> ==7074==    by 0x80528A0: main (game.bas:281)
> 

I am working on cleaning up all of common.bas, including upgrade() for 
option explicit, so that should help.

---
James
_______________________________________________
Ohrrpgce mailing list
[email protected]
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org

Reply via email to