2009/10/21 James Paige <[email protected]>: > On Tue, Oct 20, 2009 at 02:02:55PM -0700, [email protected] > wrote: >> james >> 2009-10-20 14:02:55 -0700 (Tue, 20 Oct 2009) >> 204 >> Fixed a scary text-box corrupting bug introduced in revision 2974 >> If you downloaded a nightly build yesterday or today, do not use it! download >> a new one with this fix immediately! (early nightly forced) > > For clarification, just opening your game with this nightly was not > enough to trigger the corruption. It only happened when you went into > the text box editor. > > --- > James
Oh damn! :( After a great deal of trying to reproduce this and failing (and why I never saw it when testing that commit), I finally realised it was because all the games I was testing on had old .SAY lumps which were being upgraded to initialise portrait data, and therefore written out doubly-spaced and immune from corruption (until I tried your fix, revealing all the blank boxes). I should also mention that there is a bug in dimbinsize: its return value is one too much; potentially this will cause the safeguards in storerecord to fail and write 2 bytes too many. Unfortunately, it has to do this because of buggy code somewhere that reads past the end of some loaded data in an array. This probably should be fixed; I can think of coding error scenarios that should be caught by loadrecord but wouldn't. _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
