On Sun, May 30, 2010 at 08:39:12PM +1200, Ralph Versteegen wrote: > On 29 May 2010 17:27, James Paige <[email protected]> wrote: > > I just noticed that NPC state saving/loading appears to be broken! > > If you save, and then load, the NPCs all go back to their starting > > locations! > > > > Does anybody have any idea how long this has been broken? Has it ever > > saved/restored correctly? > > > > --- > > James > > Complete disaster! > > The oldest version I am compile with my current FB build is Voxhumana, > Jan 2008. And that doesn't save NPCs.
Pepsi Ranger tested and confirmed that this was not working all the way back to a 2002 version. As far as I can tell it has always saved, and always loaded, but then it apparently it immediately gets clobbered by preparemap :P I guess that explains why I have never heard complaints from people who rearrange their NPCs in custom and then wonder why they don't move when they test playing their game. I'll comment out the saving of NPC data for the first release with the new sav format, and then we will tackle adding it as if it is a brand new feature. > If NPCs aren't being saved, do we really need to save empty hero > slots? :P That is just so ludicrous! That is a totally separate issue. Ludicrous but still apropriate. Hero commands like "set hero data" work on empty slots. I know I used hero slots to store the high score data in Don't Eat Soap. Looks like I did pre-fill those slots with dummy heroes, but I don't know if anybody else has made use of empty hero data in that way. Since the RSAV format doesnt store hero stats when they are zero, the space wastage isn't actually that bad. --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
