On 3 September 2010 15:25, James Paige <[email protected]> wrote:
> On Fri, Sep 03, 2010 at 12:45:08PM +0930, David Gowers wrote:
>> Thanks to TMC and James' help, I managed to get a working FB install
>> (of 0.21.1).
>>
>> Everything compiles okay, *except* for base64.[ch] (when I run 
>> makereload.sh).
>> They have these mysterious "restrict" keywords before 'in' and 'out'
>> parameters, that GCC doesn't like.

restrict is a new keyword added in C99, and GCC defaults to C89 with
GNU extensions. Qualifying a pointer as restricted allows certain
additional optimisations.

>> (deleting the keywords fixes the compilation issues, and reloadtest
>> then passes all it's tests ok except for Pedantic Compare W/ XML..
>> caveat below...)

Really? It works for me on windows, but I can't get xml2reload to link
with libxml2 under linux, so can't run that test. What error message
does it print?

> I had that same error right after TMC added base64.c, but then he
> changed something that fixed it a few checkins later.

That was in makegame.sh and makeedit.sh, but I forgot about makereload.sh.

>> I've attached a patch which fixes those things
>> (I think James gave me commit permissions when I started the git-svn
>> mirror, but I'm not 100% sure that these are the correct changes to
>> do. TMC should be able to apply this patch easily;
>> it's pretty trivial to apply manually, even.)

Thanks for the patch, but I had already noticed and fixed
makereload.sh a few days ago. I just didn't get around to committing
my changes to SVN.

> I am pretty sure I did give you commit access.
> But this does seem like one to defer to TMC
>
> ---
> James

>> urg. the reload stuff has other issues, too -- reloadtest assumes
>> xml2reload is in the path (rather than the current directory). Now
>> that I think about it, that could be easily worked around by making a
>> reloadtest.sh wrapper script that looks like:

Ah, thanks for noticing. I'll fix it.
_______________________________________________
Ohrrpgce mailing list
[email protected]
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org

Reply via email to