> > XOR was the wrong operator to be using. It was actually working for some > > letters but not for others. I decided it was cleaner to use a separate > > variable to track capslock state instead of making capslock modify the > > shift state. > > Oops. I meant to toggle shift state when it was a letter. Isn't XOR used for > toggling bits? As in: > shift = 1 (shift is 1) > shift = shift xor 1 (shift is now 0) > > shift = 0 > shift = shift xor 1 (shift is now 1) > > Well, I'm happy its working now anyway. :)
Ah, well, yes, that is indeed the correc tusage of xor, but because it was happening inside the FOR loop, so shift was getting toggled multiple times. So capsclock was only working for half of the scancodes. > I guess we can close bug 856 then. Yes. I think it is safe to say that one is definitely fixed. Although I tested the capslock thing with the gfx_directx backend on a Windows XP box, but it didn't seem to be getting any value at all for keyval(scCapsLock) --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
