On Thu, Dec 23, 2010 at 03:32:55PM +1300, Ralph Versteegen wrote: > On 23 December 2010 08:58, James Paige <[email protected]> wrote: > > On Wed, Dec 22, 2010 at 03:01:40AM +1300, Ralph Versteegen wrote: > >> On 22 December 2010 02:44, <[email protected]> wrote: > >> > teeemcee > >> > 2010-12-21 05:44:00 -0800 (Tue, 21 Dec 2010) > >> > 322 > >> > UI for experimental combined tag+global variable conditions, possible > >> > replacement for tag conditions. > >> > > >> > I've added a menu, accessed from Custom's main menu with Ctrl+C, with > >> > some conditions so that you can try editing them. See also the help page > >> > for that menu. > >> > > >> > These Conditions require 4 shorts of storage instead of one. > >> > --- > >> > U wip/custom.bas > >> > U wip/customsubs.bas > >> > U wip/customsubs.bi > >> > A wip/ohrhelp/condition_test.txt > >> > U wip/udts.bi > >> > >> So now I'd like some feedback on the UI. I'm pretty pleased with how > >> it turned out (aside from the hundreds of lines of difficult code); it > >> seems intuitive and easy to edit to me, but I wonder whether it is to > >> others. (Documenting it is difficult though, hence my vague > >> instructions.) However, the global variable stuff is a bit hard to > >> discover. > >> > >> The point of this test is to see whether I could create a drop-in > >> replacement for the current tag condition fields, so that we could use > >> these tag/global variable conditions for things like textbox > >> conditionals without annoying anyone who doesn't want them, and > >> without being annoying to use. What do you think? > > > > This is interesting. > > > > The top level menu when you first press CTRL+C confuses the heck out of > > me. > > > > When I choose one of the conditionals, I like the interface I see, that > > lets me choose always/never or a tag check or a global check. I do not > > see any way of deciding which global to check, but other than that I > > like what I see. > > The only way to modify the global variable was to hit backspace until > you've deleted the rest of the condition. Pepsi complained about this > too, so I've now made some changes. > > > I don't understand why there are pairs of conditionals, one defaulting > > to always and one defaulting to never. > > Just so that I can test it both ways. We have tags conditions where > the default is never (eg. textbox conditionals), and ones where it is > always (eg. door links).
Oh, I understand. > > I don't understand the meaning of the two conditionals presented to me: > > > > "Enter goes to tag browser for tag conds" is this changing the behavior > > of the enter key on tags in custom? > > > > "Enter always goes to tag browser for tag conds" this sort of sounds > > like the same thing? > > When you hit enter on a tag condition, you go to the tag picker menu. > The difference between these two pairs is that the first preserves > this old behaviour, while the second always goes to cond_editor when > you hit enter. So in addition to be a menu just to test these checks, this is ALSO a menu to decide whether this new picker gets uses for choosing tags? I thought that places where this could be supported would have to be converted one at a time? Oh, yes. Also, I was thinking, maybe we need a hidden "Experimental" menu, so we don't have to use all these special key combos from the main menu. We can just have one special key combo that gives access to all of them. --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
