On 6 January 2011 07:25, James Paige <[email protected]> wrote: > On Wed, Jan 05, 2011 at 08:11:47AM -0800, [email protected] > wrote: >> teeemcee >> 2011-01-05 08:11:47 -0800 (Wed, 05 Jan 2011) >> 95 >> Ugh, should have incremented RPG Format version when I added .DT0 record >> lengths to binsize.bin > > Just a thought, possibly a crazy one, what if we used svn revision > number for the RPG format number? That would mean upgrade warnings > between many revisions which don't actually need warnings because > nothing format-related changed... but how bad would that be? And on the > plus side, it would be impossible to forget to increment it. > > --- > James
That's been suggested an awful lot over the years! However f you don't build out of an svn or git repository (for example, if you download the nightly source) then you'll get a revision number of 0, which is awfully inconvenient. It would be nice the the build system cached the last know revision number somehow. Maybe this could also solve the problem of 'git svn info' taking longer than the actual compile under Windows! git-svn is written in fork-crazy perl, and spawning a process is something like thousands of times slower than it is on any Unix. Anyway, if that problem is solved, I'm much in favour of it. At the very least, we should throw the Future RPG File error when binsize.bin is larger than sizebinsize, because not using the real record length means probable instant corruption of a whole lump during upgrade. _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
