On Sat, 2011-10-01 at 20:29 -0400, Josef 'Jeff' Sipek wrote: > Any issues with merging this? > > http://hg.31bits.net/oi/oi-build-xcowsay/rev/e11ec815dd5b > > (https://www.illumos.org/issues/1589)
1) I'm not familiar with this package, but why are things like CFLAGS being set in source patches to Makefile.am and Makefile.in rather than as options passed to configure, which would be more self-documenting? 2) again going to the self-documenting question, why is the upstream URL provided directly in the manifest but not at all in the Makefile? _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
