On Mon, Oct 03, 2011 at 08:53:24PM +0200, Guido Berhoerster wrote: > Hi, > > * Josef 'Jeff' Sipek <[email protected]> [2011-10-02 02:29]: > > Any issues with merging this? > > > > http://hg.31bits.net/oi/oi-build-irssi/rev/32d69da311d7 > > > > (https://www.illumos.org/issues/1576) > > * there are two patches in the JDS package, are they still > applicable? > * Perl modules are delivered in the wrong place (/usr/lib/) > they need to go into /usr/perl5/vendor_perl/5.10.0/ > * perllocal.pod and .packlist files should not be packaged > * the libirc_proxy module delivered by the current JDS package > is missing > * why are there headers delivered under usr/include/irssi/src? > * /usr/etc is wrong > * I think the convention is that Solaris packages do not deliver > optional configuration (and the JDS package did not) so > irssi.conf should probably not be delivered or at least not in > /etc > * changelog, authors, and copyright files are not packaged (the > latter two could probably be merged in the .copyright file)
All good points. > In general, if you move packages from another consolidation into > oi-build please at least check the original package. Yeah, my bad. :/ Jeff. -- Bad pun of the week: The formula 1 control computer suffered from a race condition _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
