Hi Bayard, On 3 Oct 2011, at 18:11, Bayard G. Bell wrote:
> On Sat, 2011-10-01 at 20:29 -0400, Josef 'Jeff' Sipek wrote: >> Any issues with merging this? >> >> http://hg.31bits.net/oi/oi-build-gnupg/rev/6e09047a6043 >> >> (https://www.illumos.org/issues/1220) > > If the bug report is agreed, I reckon there needs to be a comment > summarising this. Anything that has to be done in addition to or as a > modification of copying out the proto tree needs some kind of reader's > notes, and manifests may be the de facto place to retain that > information, either as comments or README files. Yes, it is probably worth annotating additions/deletions to the .p5m file so that someone coming along and updating a package knows what the deviations from a "gmake sample-manifest" are. Perhaps "# Adding gpg symlink as per Illumos issue #1220" ? In s10-userland we actually store the "gmake sample-manifest" files in a sample-manifests subdirectory so that it is trivial to compare the proto areas when bumping software versions. I wonder if it's worth us doing this in oi-build. It would probably help avoid mistakes when version-bumping software where the .p5m file has been modified. Cheers, Alasdair _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
