I'm tidying up the files as requested. I've run a make test, which passes. I haven't found any DTrace patches for the 1.9 series of ruby. The SFE build of 1.9.0 doesn't have any applied. I'd suggest having two ruby packages in the repo: ruby19 with latest code and ruby18 with dtrace.
Any thoughts? On Sat, Nov 19, 2011 at 10:35 PM, Alasdair Lumsden <[email protected]>wrote: > Hi Colin, > > Great stuff! Only minor nitpicks: > > On the Makefile, you've got multiple configure options per > CONFIGURE_OPTION, and the indentation of the macros is a bit iffy. But if > you like I can tidy these up when we commit, saving you the bother. > > Did you have any luck finding out about the DTrace patches? Also did you > give make test a go? > > Cheers, > > Alasdair > > > On 11/19/11 09:54 PM, Colin Ellis wrote: > >> https://bitbucket.org/cellis_**oidev/oi-build/changeset/**4c13f4869651<https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651> >> >> On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster <[email protected] >> <mailto:[email protected]>> wrote: >> >> * Colin Ellis <[email protected] <mailto:[email protected]>**> >> >> [2011-11-12 19:40]: >> > Fixes are here: >> > >> > https://bitbucket.org/cellis_**oidev/oi-build/changeset/** >> 5bb1edf68a1d<https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d> >> >> Have you looked through the ruby 1.8 patches and checked which >> are still applicable? At least the DTrace changes should probably >> be ported over. >> Have you checked the built ruby interpeter? Running "make test" >> on the source tree after building should be an easy way to catch >> any issues. >> -- >> Guido Berhoerster >> >> ______________________________**_________________ >> oi-dev mailing list >> [email protected] <mailto:[email protected]**> >> >> http://openindiana.org/**mailman/listinfo/oi-dev<http://openindiana.org/mailman/listinfo/oi-dev> >> >> >> >> >> >> ______________________________**_________________ >> oi-dev mailing list >> [email protected] >> http://openindiana.org/**mailman/listinfo/oi-dev<http://openindiana.org/mailman/listinfo/oi-dev> >> > > > ______________________________**_________________ > oi-dev mailing list > [email protected] > http://openindiana.org/**mailman/listinfo/oi-dev<http://openindiana.org/mailman/listinfo/oi-dev> >
_______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
