Done,
https://bitbucket.org/bcoddens/oi-build/changeset/4c9c5aefabf9
Bart
On 04/12/11 23:07, Alasdair Lumsden wrote:
Hi Jeff/Bart,
On 12/ 4/11 03:45 PM, Josef 'Jeff' Sipek wrote:
On Sun, Nov 27, 2011 at 05:07:43PM +0100, Bart Coddens wrote:
Hi List,
I took the changes from Oracle userland and integrated them in
oi-build:
https://bitbucket.org/bcoddens/oi-build/changeset/1c775041a8b5
Can this be reviewed ?
Again, the repo seems to be gone.
I seem to be able to access it okay...
Bart - many thanks for providing this. Only minor nitpicks:
1. Please could you add your copyright to any files you've modified
beyond just porting the Oracle changes (or add "Copyright (c) 2011,
OpenIndiana")
2. Could you swap the 1.8.11 in the COMPONENT_ARCHIVE_URL for
$(COMPONENT_VERSION)
Since it's an update from userland-gate I see no issue in integrating
this, although we'll have to do a full resync at some point in the
near future (which will be a pita!).
Cheers,
Alasdair
_______________________________________________
oi-dev mailing list
[email protected]
http://openindiana.org/mailman/listinfo/oi-dev
_______________________________________________
oi-dev mailing list
[email protected]
http://openindiana.org/mailman/listinfo/oi-dev
