On Tue, Dec 20, 2011 at 02:30, Alasdair Lumsden <[email protected]> wrote: > A few comments: > > 1. Could you replace the OpenSolaris CDDL notice with the Illumos one > > 2. Was this taken from userland-gate or written by yourself? If taken from > userland-gate, you can keep the Oracle copyright in the Makefile and .p5m, > otherwise remove it. In either case, please do add your own copyright line. > > 3. Use a transform at the top to set etc/GeoIP.conf and GeoIP.dat > preserve=true, via: > > <transform file path=etc/GeoIP\.conf -> default preserve true> > <transform file path=usr/share/GeoIP/GeoIP\.dat -> default preserve true> > > This will ensure that if someone edits the conf or replaces the GeoIP > database that it won't be wiped out on a "pkg update"
Thank you for taking at look at this, I presumed there would be some things I wasn't aware of. It should all have been corrected in this commit: https://bitbucket.org/Tenzer/oi-build/changeset/0bdb7f9dbd18 -- Venlig hilsen / Kind regards Jeppe Toustrup (aka. Tenzer) _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
