Hi, I just committed additional changes to my personal oi-build repository. Commit can be found at https://bitbucket.org/xenol/oi-build/changeset/325c111fb2fb.
In general, I added the requested p5m file, GPLv2 license file and made minor modifications to the SMF manifest. I removed additional CONFIGURE items. However, CONFIGURE_SCRIPT has to be set, because the package won't be built. Can that be considered as a bug? Could you review the changes? Thanks, Adam On Jan 17, 2012, at 1:17 AM, Andrzej Szeszo wrote: > Hi Adam > > Things look OK in general. Nice work! > > You define additional users and groups in the p5m manifest which you have not > created yet. See > <https://bitbucket.org/openindiana/oi-build/src/2b9d1a6a8053/components/proftpd/proftpd.p5m> > for an example. Same with the directories. You define any new ones in the > p5m file. > > In general, the kind of software like zabbix agent should be delivered as > 32-bit only. I doubt there will be any benefit of the 64-bit version. > > Also, I think I would remove lines which define CFLAGS, CONFIGURE_PREFIX and > CONFIGURE_SCRIPT and use the defaults. And change the BUILD/INSTALL_64 to > BUILD/INSTALL_32. > > Thanks for working on the package. > > Cheers, > > Andrzej > > > On 01/ 9/12 12:00 AM, Adam Števko wrote: >> Hello, >> >> I have created my first package for oi-build - zabbix-agent. Zabbix is >> monitoring software used for server and service monitoring by companies all >> over the world. >> >> I had some problems building the zabbix-agent (the problem is known to me, >> but no idea how to fix it). I found workaround, but I do not find it a >> proper solution. I would like to have the Makefile and other stuff reviewed. >> The commit can be found here: >> https://bitbucket.org/xenol/oi-build/changeset/93c7d6f187db >> >> There are some things I would like to ask about: >> - if the service needs to have some directories and user/group added to the >> system, where should I define that? >> - what is the proper way to select with version to build, e.g. 64bit on >> 64bit CPU and 32bit on 32bit. I would like to take advantage of having 64bit >> software on 64bit capable CPUs. >> >> If there are any problems regarding the Makefile, please let me know. I >> would like to fix them and have zabbix-agent added to the oi-build. When >> agent is done and committed to the oi-build, I will follow with >> zabbix-server and zabbix-proxy. >> >> xenol >> _______________________________________________ >> oi-dev mailing list >> [email protected] >> http://openindiana.org/mailman/listinfo/oi-dev _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
