As you can see - line not changed: only removed some lines PKG_MACROS += GNU_ARCH="$(GNU_ARCH)"
About copyright for ips2deb tool - changed year - it is not critical for review. -Igor From: Andrew Stormont <[email protected]> Reply-To: OpenIndiana Developer mailing list <[email protected]> Date: Mon, 13 Feb 2012 13:01:04 +0000 To: OpenIndiana Developer mailing list <[email protected]> Subject: Re: [oi-dev] review: gcc as primary compiler > Hi Igor, > >> > About GNU_ARCH - it is not for this review and not changed. > > Line 40 of components/binutils/Makefile: > > -COMPILER = gcc > - > -PARCH = $(MACH:i386=i386-pc) > -PARCH64 = $(MACH64:amd64=x86_64-pc) > -GNU_ARCH = $(PARCH:sparc=sparc-sun)-solaris$(SOLARIS_VERSION) > -GNU64_ARCH = $(PARCH64:sparcv9=sparcv9-sun)-solaris$(SOLARIS_VERSION) > - > PKG_MACROS += GNU_ARCH="$(GNU_ARCH)" > >> > About copyright - they are no changes in copyright on this change set. > Line 3 of tools/MFT.pm: > -# 2010-2011, Copyright (c) Igor Kozhukhov. All rights reserved. > +# 2010-2012, Copyright (c) Igor Kozhukhov. All rights reserved. > Thanks, > Andrew > > > From: Igor Kozhukhov <[email protected]> > Reply-To: OpenIndiana Developer mailing list <[email protected]> > Date: Mon, 13 Feb 2012 15:40:09 +0400 > To: OpenIndiana Developer mailing list <[email protected]> > Subject: Re: [oi-dev] review: gcc as primary compiler > > About GNU_ARCH - it is not for this review and not changed. > It is value is using for GCC builds. > This review about changes to GCC as primary compiler. > About copyright - they are no changes in copyright on this change set. > I'll update copyright info for next components. > > It is big chanegset and can we applied to illumos-userland, if all will agree. > > -Igor > > From: Andrew Stormont <[email protected]> > Reply-To: OpenIndiana Developer mailing list <[email protected]> > Date: Mon, 13 Feb 2012 11:24:13 +0000 > To: OpenIndiana Developer mailing list <[email protected]> > Subject: Re: [oi-dev] review: gcc as primary compiler > >> Hi Igor, >> >> I've only had a quick scan through the changes but I'd say on the whole they >> look to be an improvement over what we currently have. However, there are >> two things I think you need to look at: 1) You still have some things that >> are copyright yourself 2) You do not seem to set GNU_ARCH but you are passing >> it in PKG_MACROS for at least one package. >> >> Thanks, >> Andrew >> >> From: Igor Kozhukhov <[email protected]> >> Reply-To: OpenIndiana Developer mailing list <[email protected]> >> Date: Mon, 13 Feb 2012 14:52:55 +0400 >> To: OpenIndiana Developer mailing list <[email protected]> >> Subject: Re: [oi-dev] review: gcc as primary compiler >> >> At this moment illumos-userland - it is fork of dilos-userland - changes will >> be updated correctly. >> >> dilos-userland - it is public repo, not a private. >> >> -Igor >> >> From: Bayard Bell <[email protected]> >> Reply-To: OpenIndiana Developer mailing list <[email protected]> >> Date: Mon, 13 Feb 2012 10:42:43 +0000 >> To: OpenIndiana Developer mailing list <[email protected]> >> Subject: Re: [oi-dev] review: gcc as primary compiler >> >>> As this is also a policy issue, let's finalize this at #oi-meeting. >>> >>> Also, could we please submit changes to userland via forks of the public >>> illumos-userland or oi-build (with the roll-out of illumos-userland under >>> discussion at the next #oi-meeting, one item should be working off it alone >>> going forward)? Using a fork of a private repo that may or may not diverge >>> substantially from what everyone else is using makes it harder for people to >>> evaluate. >>> >>> On Mon, Feb 13, 2012 at 10:30 AM, Igor Kozhukhov <[email protected]> >>> wrote: >>>>> >>>>> Hello All, >>>>> >>>>> Please review: >>>>> https://bitbucket.org/dilos/dilos-userland/changeset/5e3079f6ad40 >>>>> >>>>> https://www.illumos.org/issues/2113 >>>>> It is big changeset with changes for "setup GCC as default compiler" >>>>> >>>>> --- >>>>> Best regards, >>>>> Igor Kozhukhov >>>>> IRC# igork >>>> >>>> _______________________________________________ >>>> oi-dev mailing list >>>> [email protected] >>>> http://openindiana.org/mailman/listinfo/oi-dev >>>> >>> >>> _______________________________________________ oi-dev mailing list >>> [email protected]http://openindiana.org/mailman/listinfo/oi-dev >> _______________________________________________ oi-dev mailing list >> [email protected]http://openindiana.org/mailman/listinfo/oi-dev >> _______________________________________________ oi-dev mailing list >> [email protected]http://openindiana.org/mailman/listinfo/oi-dev > _______________________________________________ oi-dev mailing list > [email protected]http://openindiana.org/mailman/listinfo/oi-dev > _______________________________________________ oi-dev mailing list > [email protected] http://openindiana.org/mailman/listinfo/oi-dev
_______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
