Hi Adam, My general copyright note (MyGCN):
Since IANAL, I am not sure whether it is okay to remove previous Oracle copyrights from some files. I personally would leave the copyrights there, just to be safe. > From: Adam Števko <[email protected]> > To: OpenIndiana Developer mailing list <[email protected]> > Sent: Tuesday, January 22, 2013 4:00 PM > Subject: [oi-dev] Compiler migration #2 > > > Hi guys, > > I am continuing on completing studio -> gcc compiler migration. As this is > something, which will take a century to complete, I have come to a conclusion > that I will directly update stuff and make sure it is buildable by gcc44. > > At the moment, I have upgrade build-related GNU stuff: m4, automaker, > autoconf and some software, which I didn't commit, but builds with gcc44 > cleanly. > > I would like review for these: > > m4: https://hg.openindiana.org/users/xenol/oi-build/rev/c4d08e3efd26 m4: - minor nit: why a change at line 41 in the Makefile? 1.26 -CONFIGURE_PREFIX = /usr/gnu 1.27 +CONFIGURE_PREFIX = /usr/gnu - Some copyright related note removal in m4.license (see the MyGCN above) - Oracle copyright removed from m4.p5m (see the MyGCN above) - pkg.description removed from m4.p5m. why? - opensolaris.arc_url removed from m4.p5m. intentional? why? - otherwise: LGTM > automake: https://hg.openindiana.org/users/xenol/oi-build/rev/72207fade556 automake: - shouldn't the automake-1.13/automake.p5m go to a separate directory? something like automake/automake.p5m. With the current implementation once we will integrate version 1.14 we will need to move this file to a new location - otherwise LGTM > autoconf: https://hg.openindiana.org/users/xenol/oi-build/rev/2bcc9f5561c6 autoconf: - Basically LGTM - Oracle copyright removed from autoconf.p5m (see the MyGCN above) - is opensolaris.arc_url removal from autoconf.p5m intentional? > help2man: https://hg.openindiana.org/users/xenol/oi-build/rev/1dcbf893845c help2man: - since there is no conflict with other Solaris/illumos/OI tools I'd put this into /usr/bin/ (insteadd of /usr/gnu) - otherwise: LGTM > python, quagga, readline, rtorrent: > https://hg.openindiana.org/users/xenol/oi-build/rev/95915ef8b395 python, quagga, readline, rtorrent: - LGTM > > I will push libtool update in the near future. > > I am sorry that I have everything in one repository, but this way it is more > comfortable for me. Thanks for understanding. Thanks. -- +-------------------------------------------+ | Marcel Telka e-mail: [email protected] | | homepage: http://telka.sk/ | | jabber: [email protected] | +-------------------------------------------+ _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
