Hi guys,

I would like to merge some changes to transforms and build environments, but I 
would like a review before I do:

https://github.com/xen0l/oi-userland/commit/b29ae5f07288eee6a5cc59cd7751770c7fb17cc9
https://github.com/xen0l/oi-userland/commit/cd9a16b7259c9dbca4d3ea45cc3c3d36d5d8f2f8
- removal of Oracle CDDL templates, import of illumos ones. This will change 
sample-manifest license header.

https://github.com/xen0l/oi-userland/commit/ef4e018188cf13e1535ee00109d03046705595ce
- some minor contact modifications in the README file

https://github.com/xen0l/oi-userland/commit/6842d7ffb4ed409a276f9e06a8e5310ad7d5764f
- Alasdair's issue (https://www.illumos.org/issues/2682), which brings in sane 
default for configuration environment. Many components already sets these in 
their Makefile and I don't see reasons, why we shouldn't make them default.
I commented out CONFIGURE_OPTIONS as I found them redundant. From my 
understanding, configure will set these to environment variables, so 
CONFIGURE_ENV should be sufficient. If there are any objections I will restore 
CONFIGURE_OPTIONS. I also ask for an opinion if there is a point in setting 
these value for other _ENV variables (COMPONENT_BUILD_ENV, 
COMPONENT_INSTALL_ENV, COMPONENT_TEST_ENV, COMMON_PERL_ENV, PYTHON_ENV).

https://github.com/xen0l/oi-userland/commit/db2ec7b9210fb8e1bc134830e22c1f0935121594
https://github.com/xen0l/oi-userland/commit/05394c0cd3765edc077327b28bc0116ec5537be5
- Alasdair's issue (https://www.illumos.org/issues/2683), which fixes setting 
correct LDFLAGS for components. There were problems mostly with 64-bit software 
and the build would fail because linker picked up wrong LDFLAGS. LINKER 
variable is taken from ec-userland and is used to set the correct LDFLAGS. In 
the second commit, the linker is switched to ccs instead of gcc.

My other change I wanted to integrate was adding "-i" to "env", which will 
ignore user environment variables and use only the ones found in _ENV. However, 
when I tested this several components failed their build, so this needs more 
work/research. Any comments on this?

Cheers,
Adam

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
oi-dev mailing list
[email protected]
http://openindiana.org/mailman/listinfo/oi-dev

Reply via email to