Hello, I have been playing with Danger today and I was able to put up together a system, which will check incoming pull requests for style fixes / notify people about things that are usually forgotten e.g. bumping COMPONENT_REVISION, claiming copyrights, WS_TOP -> WS_MAKE_RULES, adding REQUIRED_PACKAGES and etc.
Workflow (how it work once merged): - open a PR against openindiana/oi-userland - Travis (3rd party CI service) will be notified and will spawn Ubuntu container, which will run Danger and do the magic - results will be posted in a form of Github reviews to the PR and contributor can check it. If problems arise, he can fix it until the build passes the check Example: https://github.com/xen0l/oi-userland/pull/3 <https://github.com/xen0l/oi-userland/pull/3> I would be interested in feedback on usability / text formatting (e.g. file paths can be made a link to file directly) / additional check types. I am also investigating option of inline commenting. Cheers, Adam
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ oi-dev mailing list [email protected] https://openindiana.org/mailman/listinfo/oi-dev
