This PR (pull request) seems fine to me; I can only agree that improving the pkglint tool, without changing it in a incompatible way, should be an improvement.
The 32bit path for 64bit bin or 32bit bin in 64bit path checks, are useful, and I like the Solaris and OpenIndiana / OpenSolaris setup for 32bit/64bit paths. Hopefully this feature remains in there. For Smalltalk / Squeak for example, the 32bit binaries for 32bit Smalltalk VM's remain useful, and Squeak is built in both 32bit and 64bit; I would not like having to build Squeak 64bit only, since there are a lot of 32bit Smalltalk images out there which are opened by the 32bit binary. Anyway pkglint enforces the layout of those paths, so pkglint is a great help. Regards, David Stes ----- Op 7 feb 2022 om 8:39 schreef oi-dev oi-dev@openindiana.org: > the main idea of pkglint userland runpath check is to prevent shipping bins in > package whith runpaths like > > /export/home/user/myprivate/builddir/lib > > wrong architecture like 32bit path for 64bit bin or standard paths which knows > the ldd already. > > > Our pkglint userland checker complains about runpaths which are correct. So we > should update this tool. > > > e.g. > ERROR userland.action001.3 bad RUNPATH, 'opt/SUNWsamfs/bin/archive' includes > '/opt/SUNWsamfs/lib' > ERROR userland.action001.3 bad RUNPATH, 'opt/SUNWsamfs/bin/notify' includes > '/opt/SUNWsamfs/lib' > ERROR userland.action001.3 bad RUNPATH, 'opt/SUNWsamfs/bin/request' includes > '/opt/SUNWsamfs/lib' > these false positives we can get rid off by the version used by > solaris-userland. > https://github.com/OpenIndiana/oi-userland/pull/7710 > > But look deeper there is some more work to do. > This version will not accept runpaths like /usr/gcc/.. and /usr/mariadb/..., > which are correct. > We can allow this paths per default. The most complete solution would be to > allow this paths, if there resolved dependencies for the related bins > > Any thoughts? > -- > Carsten > > _______________________________________________ > oi-dev mailing list > oi-dev@openindiana.org > https://openindiana.org/mailman/listinfo/oi-dev _______________________________________________ oi-dev mailing list oi-dev@openindiana.org https://openindiana.org/mailman/listinfo/oi-dev