https://github.com/OpenImageIO/oiio/pull/108
This eliminates the silly 'width' argument to maketx --filter : now you just specify the filter name, and it chooses the appropriate width. Also augmented the Filter classes with some static methods that let an application query what filters are available and some vital stats about each of them (including a recommended width, whether it is scaling or windowing, and so on.), and some very minor cleanup to ImageBufAlgo::resize to eliminate a redundant parameter. Oops, I forgot to post this to the mail list. It's already got a LGTM from Jeremy, but I wanted to give others a chance weigh in. There are actually two outstanding issues that might merit some discussion: 1. Merge into 0.10, or not? It's got a very minor change to the ImagBufAlgo::resize function (eliminated a redundant parameter) and of course a change to the command line arguments of maketx. Of course, both are new items themselves, so maybe changing them is not going to cause pain to anyone. 2. Right now, the same filter is used for both the MIPmap generation as well as the upscale to power of 2. On one hand, in an ideal world you'd use different filters for these -- perhaps a lanczos3 for the MIP generation (downsampling) and Blackman-Harris or bspline for the upsampling. But I don't know if you'd ever really notice a problem if you used the same for both, and the pow2 upsampling is both optional and not particularly recommended. So I'm tempted to live with this limitation (same filter for both), but if somebody complains and has an example texture that it doesn't work well for, I can later add a --upresfilter or something to allow that to be separately specified. Any objections? -- Larry Gritz [email protected] _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
