Brecht, Larry (whoever else...) There is also another issue...
src/ptex.imageio/ptex/PtexPlatform.h FreeBSD does not have alloca.h as part of it's sources, so that needs to be a conditional as well. It's pretty simple as the one function OIIO needs from it is defined in stdlib.h on FreeBSD already, so simply not #include'ing alloca.h for FreeBSD does the trick.... Cheers! On Thu, Dec 8, 2011 at 1:37 PM, Brecht Van Lommel <reply+i-2493333-267c6c60a4cba4ed6d573a923ce0eb6da2b6c2b9-1146...@reply.github.com> wrote: > First is the fix for platform detection in cmake, which should now work for > unixes other than Linux and Darwin. > > Also removed the defines LINUX and LINUX64, they were only used to set > imagesize_t, and using uint64_t seems simpler and more reliable than to keep > adding checks for more operating systems. > > The last change disables using GCC atomic builtins on FreeBSD 32bit. This is > somewhat arbitrary, and I'm not sure why _GLIBCXX_ATOMIC_BUILTINS is defined > when they are apparently not available (link errors). > > A better solution might be possible, but it's not clear to me how to detect > this case properly, and it should not harm other platforms. > > You can merge this Pull Request by running: > > git pull https://github.com/brechtvl/oiio dev-freebsd-build > > Or you can view, comment on it, or merge it online at: > > https://github.com/OpenImageIO/oiio/pull/201 > > -- Commit Summary -- > > * Arbitrary unix platform detection, use uint64_t for imagesize_t. > * Use TBB instead of gcc builtin atomics on non-x86_64 BSD. > > -- File Changes -- > > M src/cmake/platform.cmake (7) > M src/include/imageio.h (7) > M src/include/thread.h (13) > > -- Patch Links -- > > https://github.com/OpenImageIO/oiio/pull/201.patch > https://github.com/OpenImageIO/oiio/pull/201.diff > > --- > Reply to this email directly or view it on GitHub: > https://github.com/OpenImageIO/oiio/pull/201 > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
