Fix minor buglet in to_native_rectangle -- contiguous was calculated 
incorrectly for non-native data, leading to later errors in copying the buffers 
for certain format conversions, as well as leading to unnecessary contiguizing 
copies in other cases.

Along for the ride (found while tracking down that bug, but turned out not to 
be the issue): fix iconvert internals to handle int32, uint32 conversion cases; 
also move the "nocopy" test outside the conditional where it's more clear (and 
maybe more correct).


You can merge this Pull Request by running:

  git pull https://github.com/lgritz/oiio lg-contig

Or you can view, comment on it, or merge it online at:

  https://github.com/OpenImageIO/oiio/pull/252

-- Commit Summary --

* iconvert internals: handle int32, uint32 conversion cases; also move the 
"nocopy" test outside the conditional where it's more clear (and maybe more 
correct).
* Fix minor buglet in to_native_rectangle -- contiguous was calculated 
incorrectly for non-native data, leading to later errors in copying the buffers 
for certain format conversions, as well as leading to unnecessary contiguizing 
copies in other cases.

-- File Changes --

M src/iconvert/iconvert.cpp (8)
M src/libOpenImageIO/imageoutput.cpp (11)

-- Patch Links --

  https://github.com/OpenImageIO/oiio/pull/252.patch
  https://github.com/OpenImageIO/oiio/pull/252.diff

--- 
Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/pull/252
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

Reply via email to