The patch looks ok (and, as far as I'm concerned, satisfies the qualifying
patch requirement), but I'm wondering why it's helpful. The status bar already
gives the zoom ratio. What is the argument for adding a percentage at the
expense more space on the status bar? I could be convinced to accept this if
people prefer a zoom percentage, but it's not a request I recall ever having
heard discussed before.
-- lg
On Mar 20, 2012, at 6:46 AM, Pankaj wrote:
> Hi! this is Pankaj, I would be applying for GSoC this year with oiio. As it
> is mentioned in wiki that some contribution to code is required for the
> application to be considered. This is my first tiny modification.
> It just shows Zoom% also along with the ration in iv status bar.
>
> Would be sending some more git review/pull requests by next weekend.
>
> You can merge this Pull Request by running:
>
> git pull https://github.com/panks/oiio master
>
> Or you can view, comment on it, or merge it online at:
>
> https://github.com/OpenImageIO/oiio/pull/256
>
> -- Commit Summary --
>
> * Patch to show Zoom% in status bar of Imageviewer.
>
> -- File Changes --
>
> M src/iv/imageviewer.cpp (12)
>
> -- Patch Links --
>
> https://github.com/OpenImageIO/oiio/pull/256.patch
> https://github.com/OpenImageIO/oiio/pull/256.diff
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenImageIO/oiio/pull/256
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
