I agree that the current working directory (since iv is often run from the
command line) is the right default.
Many of the other changes look like great ideas. I need to play around with it
for a while, but when I have done so, I'll merge in whichever individual
commits look like they should be committed.
Casian, looks like it's about time for you to get a CLA to me.
-- lg
On Mar 20, 2012, at 4:27 PM, Stephen Parker wrote:
> on linux, the default behavior for iv file dialogues is `cwd`. so you're open
> dialogue defaults to the path the executable? or were you just running it
> from it's build location? anyway, I don't believe we should change that
> behavior unless it's broken somehow.
>
>
>
> From: skelet
> <reply+i-3735263-3511f84d810b20bfd7404ad55c24485338ae94fb-1146...@reply.github.com>
> To: oiioecho <[email protected]>
> Sent: Tuesday, March 20, 2012 1:37 PM
> Subject: [Oiio-dev] [oiio] Various small improvements for IV (#257)
>
> Hello,
>
> This is Casian, introduced myself on the ML yesterday I believe, regarding
> GSoC.
>
> I gave IV a spin and noticed a couple of things that didn't seem consistent
> with what I was used with. So I decided to try to fix them.
>
> There are mainly improvements to the file dialogs. The open dialog starts on
> homeDir() - seems more appropriate than the directory of the application's
> executable. It also remembers the path between successive opens. Put some
> filters for the types of images supported by OIIO, to give a consistent feel
> with other applications. Anyway, I believe we don't want to see binaries and
> strange files when looking to open images.
>
> I have a bunch of directories with a huge number of images, so I felt that an
> add directory feature was necessary.
>
> Noticed #include <QtGui>, that isn't good for compile time afaik. I think
> there are some recommendations in KDE techbase regarding this. Anyway,
> changed that towards including each class separately and measured the compile
> times - apparently this change makes IV compile 30% faster.
>
> IV behaved strangely when an image was closed, it didn't change the displayed
> image and that was quite confusing. Found a FIXME and tried to put some code
> that produces ok behavior in that case. I hope it's good enough.
>
> As a KDE user, I'm used to Gwenview, which navigates through images using
> space and backspace. So I thought adding these keys for navigation in IV
> besides the arrows and PgUp/Down doesn't hurt.
>
>
> You can merge this Pull Request by running:
>
> git pull https://github.com/skelet/oiio skelet
>
> Or you can view, comment on it, or merge it online at:
>
> https://github.com/OpenImageIO/oiio/pull/257
>
> -- Commit Summary --
>
> * Use space and backspace too, for navigating images
> * Remember the last open dialog directory for IV
> * Reorganize Qt includes, seeking a faster compilation
> * Fix behaviour of IV after closing an image
> * Use filters for different types of images in dialogs
> * Add open directory feature
>
> -- File Changes --
>
> M src/iv/imageviewer.cpp (120)
> M src/iv/imageviewer.h (25)
> M src/iv/ivgl.cpp (7)
> M src/iv/ivinfowin.cpp (6)
> M src/iv/ivmain.cpp (2)
> M src/iv/ivpref.cpp (6)
>
> -- Patch Links --
>
> https://github.com/OpenImageIO/oiio/pull/257.patch
> https://github.com/OpenImageIO/oiio/pull/257.diff
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenImageIO/oiio/pull/257
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
