I'm not exactly sure what purpose the Over class serves. (Feel free to convince me otherwise.) I was thinking just one exposed function per image operation in the .h file, and a few (static, local to the module) functions inside the implementation cpp file.
I would put the ROI class definition in imagebuf.h so that we can make ImageBuf methods that directly reference them, if we want. I would put the one public function, ImageBufAlgo::over (dst, src1, src2, roi, threads), in imagebufalgo.h. I want all the publicly exposed functions for IBA to go in this one file. I would put the implementation in imagebufalgo.cpp, but if it gets too large, we can split it into multiple files, roughly broken into major areas or related functionality. I think there's certainly no reason to split EVERY image operation into a separate .cpp file, though we would want to do so for any whose individual implementations are very large and complex, or that we would want to optionally disable at build time, or that require a unique external dependency. On Jun 9, 2012, at 5:45 AM, Stefan Stavrev wrote: > Taking into consideration everything said yesterday, I created a class for > Over's API. We can improve design and add things later, I vote for starting > implementation of what we already have as soon as possible. > > http://pastebin.com/H46c9ZG1 > > Some questions: > > 1. It would be nice to have *.h and *.cpp for each algorithm's class, rather > than throwing the class in ImageBufAlgo.cpp. If you agree, where do I place > the files over.h and over.cpp? > 2. Where should I place the ROI class? > > Stefan > -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
